Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix building libz-sys #420

Merged
merged 7 commits into from
Feb 22, 2024
Merged

fix: fix building libz-sys #420

merged 7 commits into from
Feb 22, 2024

Conversation

FelixMoelder
Copy link
Member

Update Cargo.lock for building zlib-sys on macOS.

@fxwiegand fxwiegand self-requested a review February 22, 2024 14:09
@coveralls
Copy link

coveralls commented Feb 22, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8007045287

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 79.791%
Files with Coverage Reduction New Missed Lines %
src/bam/record.rs 1 76.72%
Totals Coverage Status
Change from base Build 7814288779: -0.03%
Covered Lines: 2440
Relevant Lines: 3058
💛 - Coveralls

@FelixMoelder FelixMoelder reopened this Feb 22, 2024
@fxwiegand
Copy link
Contributor

Seems to solve the CI problems for macOS! LGTM!

@FelixMoelder FelixMoelder merged commit 01c8849 into master Feb 22, 2024
10 of 11 checks passed
@FelixMoelder FelixMoelder deleted the fix/osx branch February 22, 2024 16:05
@github-actions github-actions bot mentioned this pull request Feb 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fxwiegand fxwiegand fxwiegand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FelixMoelder @coveralls @fxwiegand